[release/8.0] Support assignment to multiple refs in trim analyzer #90936
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
marek-safar and
sbomer
as code owners
ghost
added
the
linkable-framework
dotnet-issue-labeler
bot
added
the
area-Tools-ILLink
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas Issue DetailsBackport of #90287 to release/8.0 /cc @sbomer Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
|
@sbomer I can merge it for you, just ping me. No need to click on "Update branch" (it will restart the CI). There is a CI failure in browser-wasm saying there's not enough disk space, so I assume it's unrelated. I re-ran the failed legs just in case, but they were showing up as warnings so I might just merge if they happen again. |
Backport of #90287 to release/8.0
/cc @sbomer
Customer Impact
Analyzer would throw an exception, producing the following error with certain specific code patterns involving assignments to multiple refs:
For example, the following code would produce this error:
Testing
Added testcases to validate that this and similar patterns no longer throw and produce reasonable analysis results (even though it is unlikely that such a pattern will be used in a way that is meaningful for the purpose of trim warnings).
Risk
Low risk. This fixes an analyzer crash without changing the analysis results for existing code. There's a fair amount of code in this change, but any risk is limited to the analyzer that runs during build, not directly affecting the runtime behavior or the output binary.